Don't allow empty string as authors and description metadata #1728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could you pelase take a look at the broken test? thanks |
inosik
force-pushed
the
bugfix/missing-metadata
branch
from
397fb3f to
08b7d3b
Compare
|
Missed that one, should pass now. |
|
An integration test for |
|
Thanks. This is now in v 3.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paket produces invalid metadata for packages, which only have
type projectin theirpaket.templatefile.Those packages look ok, but cause problems further down the road, i. e. when trying to upload them or when using test adapters installed via Paket. Probably when trying to install them with NuGet, too, because the non-descriptive error message in VS comes from NuGet.Core.
/cc @biehlermi